Conversation
- replaced overflow_container and secondary_overflow with single overflow_containers setting (comma-separated)
- added configurable "Trash to Dump" section, instead of hardcoded herb/food/junk
|
Probably want to remove food, herb, and junk toggles in the sell type section since they are covered by the trash to dump section. |
I kept old functionality that it still checks the "sell" types in order to then trash/junk stuff. So you have to have both checked in order to actually dump. Couldn't think of a better way to safeguard. That way it tries to sell first any category and then dumps (just for food/herbs/junk it can't really sell, but still needed to be checked) |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to fe6a965 in 10 seconds. Click for details.
- Reviewed
297lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_nT2saXWczgXt3NV2
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
force saving of migrated settings for overflow upon migration
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to bdb422b in 9 seconds. Click for details.
- Reviewed
391lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_zcx6zmo34aUkKYgN
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Updated the total tips calculation to include a custom withdraw amount setting for the locksmith.
Important
Refactor
eloot.licto consolidate overflow settings, add configurable trash dumping, and fix script parameter bug.overflow_containerandsecondary_overflowwithoverflow_containers(comma-separated) ineloot.lic.trash_dump_typessetting for configurable trash dumping.migrate_overflow_settings()to convert old overflow settings to new format.overflow_containersandtrash_dump_typessettings.eloot.lic.This description was created by
for bdb422b. You can customize this summary. It will automatically update as commits are pushed.