Closed
Conversation
Fixing the line match for box_loot_ground
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 2088671 in 21 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_nLI0GpAeETjW68Cd
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| @@ -4563,7 +4563,7 @@ module ELoot # Room looting | |||
|
|
|||
| box_list.each do |box| | |||
Contributor
There was a problem hiding this comment.
Ensure the regex exactly matches the game's current locked message. If the message changes in the future, consider parameterizing or expanding the match to cover variations.
Contributor
|
incorporated into fix(eloot.lic): v2.7.1 multiple fixes #2216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the line match for box_loot_ground
Important
Fixes line match for
box_loot_groundineloot.licby updating regex pattern to correctly identify locked boxes.box_loot_groundineloot.licby changing regex pattern inmatch?method from/That is locked/to/It appears to be locked/.This description was created by
for 2088671. You can customize this summary. It will automatically update as commits are pushed.