Skip to content

Update eloot.lic#2224

Closed
ServerFailure wants to merge 1 commit intoelanthia-online:masterfrom
ServerFailure:patch-18
Closed

Update eloot.lic#2224
ServerFailure wants to merge 1 commit intoelanthia-online:masterfrom
ServerFailure:patch-18

Conversation

@ServerFailure
Copy link
Contributor

@ServerFailure ServerFailure commented Feb 1, 2026

Fixing the line match for box_loot_ground


Important

Fixes line match for box_loot_ground in eloot.lic by updating regex pattern to correctly identify locked boxes.

  • Behavior:
    • Fixes line match for box_loot_ground in eloot.lic by changing regex pattern in match? method from /That is locked/ to /It appears to be locked/.
  • Misc:
    • No other changes or additions in the script.

This description was created by Ellipsis for 2088671. You can customize this summary. It will automatically update as commits are pushed.

Fixing the line match for box_loot_ground
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 2088671 in 21 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_nLI0GpAeETjW68Cd

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@@ -4563,7 +4563,7 @@ module ELoot # Room looting

box_list.each do |box|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the regex exactly matches the game's current locked message. If the message changes in the future, consider parameterizing or expanding the match to cover variations.

@Deysh
Copy link
Contributor

Deysh commented Feb 1, 2026

incorporated into fix(eloot.lic): v2.7.1 multiple fixes #2216

@Deysh Deysh closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants