fix: save stream selection per media for audio and subtitles #133
+253
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't think the hardcoded |
Doezer
force-pushed
the
bug/fix-subtitle-saving
branch
2 times, most recently
from
dbae8dd to
5c7f90b
Compare
Doezer
force-pushed
the
bug/fix-subtitle-saving
branch
from
c56d581 to
5cbec23
Compare
Contributor
Author
|
@edde746 I updated the PR to use the existing map. Also rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug (or maybe more of a gap) that doesn't allow saving the subtitle selection for media. With this change, Plezy now saves the user selection to Plex when they change the subtitle.
I didn't remove the existing behaviour of saving the language to the series (for tv shows), but it might be redundant for movies.
I'm working on a third PR to fix the issue of not actually using the subtitle track sent by Plex as the selected one.