Skip to content

add session closing callback API #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Jun 23, 2025

See #2008

Copy link

PR missing one of the required labels: {'dependencies', 'documentation', 'breaking-change', 'bug', 'new feature', 'internal', 'enhancement'}

@wyfo wyfo requested a review from milyin June 23, 2025 08:41
Copy link

PR missing one of the required labels: {'new feature', 'documentation', 'breaking-change', 'internal', 'bug', 'dependencies', 'enhancement'}

@wyfo wyfo added the new feature Something new is needed label Jun 23, 2025
@wyfo wyfo marked this pull request as draft June 23, 2025 09:00
@wyfo wyfo requested a review from OlivierHecart June 23, 2025 09:00
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (6f9cfa0) to head (663cbb5).

Files with missing lines Patch % Lines
zenoh/src/api/session.rs 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   71.15%   70.99%   -0.16%     
==========================================
  Files         367      367              
  Lines       61866    61901      +35     
==========================================
- Hits        44019    43949      -70     
- Misses      17847    17952     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wyfo wyfo force-pushed the closing-callback branch from ae089ad to 16ae406 Compare June 23, 2025 09:18
@wyfo wyfo force-pushed the closing-callback branch from 790f3b3 to 663cbb5 Compare June 23, 2025 10:31
@wyfo wyfo requested a review from yellowhatter June 23, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant