Skip to content

Advanced sub closing callback #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Jun 23, 2025

Based on #2009
Closes #2008

Copy link

PR missing one of the required labels: {'dependencies', 'internal', 'documentation', 'new feature', 'enhancement', 'bug', 'breaking-change'}

@wyfo wyfo requested review from milyin and OlivierHecart June 23, 2025 08:55
@wyfo wyfo added the bug Something isn't working label Jun 23, 2025
@wyfo wyfo marked this pull request as draft June 23, 2025 09:00
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (6f9cfa0) to head (d956ffd).

Files with missing lines Patch % Lines
zenoh/src/api/session.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   71.15%   70.95%   -0.20%     
==========================================
  Files         367      367              
  Lines       61866    61918      +52     
==========================================
- Hits        44019    43936      -83     
- Misses      17847    17982     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wyfo wyfo force-pushed the advanced-sub-closing-callback branch from d956ffd to 3fe2c38 Compare June 23, 2025 10:31
@wyfo wyfo requested a review from yellowhatter June 23, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced subscriber handler is not closed with session
1 participant