Skip to content

repo: rework fix for logging build issues #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawelrutkaq merged 1 commit into from
Mar 4, 2026
Merged

repo: rework fix for logging build issues #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ build --credential_helper=*.qnx.com=%workspace%/scripts/internal/qnx_creds.py

# Common test flags for all platforms
test --test_output=errors
test --@score_logging//score/mw/log/flags:KRemote_Logging=False
test --@score_baselibs//score/json:base_library=nlohmann
test --cxxopt=-Wno-deprecated-declarations

Expand All @@ -36,6 +35,7 @@ build:toolchain_common --incompatible_strict_action_env
build:toolchain_common --host_platform=@score_bazel_platforms//:x86_64-linux
## Ferrocene must be common compiler for HOST. To ensure metadata compatibility for proc macro crate
build:toolchain_common --extra_toolchains=@score_toolchains_rust//toolchains/ferrocene:ferrocene_x86_64_unknown_linux_gnu
build:stub --@score_baselibs//score/mw/log/flags:KRemote_Logging=False
build:stub --@score_logging//score/mw/log/flags:KRemote_Logging=False
build:stub --@score_baselibs//score/json:base_library=nlohmann

Expand Down
1 change: 1 addition & 0 deletions examples/cpp_lifecycle_app/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ cc_binary(
visibility = ["//visibility:public"],
deps = [
"//src/lifecycle_client_lib",
"@score_logging//score/mw/log",
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpp_lifecycle_app now directly depends on @score_logging//score/mw/log while //src/lifecycle_client_lib already pulls in @score_baselibs//score/mw/log transitively. Unless the example truly needs both implementations, this extra dep is likely redundant and may create inconsistent linking/flags compared to the rest of the repo. Prefer relying on the transitive dep or switching the example to the same @score_baselibs//score/mw/log target used elsewhere (whichever is intended).

Suggested change
"@score_logging//score/mw/log",

Copilot uses AI. Check for mistakes.
],
)
2 changes: 1 addition & 1 deletion src/control_client_lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ cc_library(
"//src/launch_manager_daemon/common:log",
"//src/launch_manager_daemon/common:osal",
"@score_baselibs//score/concurrency/future",
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
],
)
4 changes: 2 additions & 2 deletions src/launch_manager_daemon/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ cc_binary_with_common_opts(
"//src/launch_manager_daemon/health_monitor_lib:health_monitor",
"//src/launch_manager_daemon/process_state_client_lib:process_state_client",
"@flatbuffers",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/result",
"@score_logging//score/mw/log",
],
)

Expand Down Expand Up @@ -84,7 +84,7 @@ cc_library(
"//src/launch_manager_daemon/common:log",
"//src/launch_manager_daemon/health_monitor_lib:health_monitor",
"@flatbuffers",
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/result",
],
)
10 changes: 5 additions & 5 deletions src/launch_manager_daemon/health_monitor_lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ cc_library_with_common_opts(
],
visibility = ["//src:__pkg__"],
deps = [
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
],
)

Expand All @@ -68,7 +68,7 @@ cc_library_with_common_opts(
visibility = ["//src:__pkg__"],
deps = [
"//src/launch_manager_daemon/process_state_client_lib:process_state_client",
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
],
)

Expand Down Expand Up @@ -118,7 +118,7 @@ cc_library_with_common_opts(
"src/score/lcm/saf/logging",
],
deps = [
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
],
)

Expand All @@ -138,7 +138,7 @@ cc_library_with_common_opts(
deps = [
":config",
"//src/launch_manager_daemon/recovery_client_lib:recovery_client",
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
],
)

Expand Down Expand Up @@ -305,7 +305,7 @@ cc_library_with_common_opts(
":supervision",
":timers",
"@flatbuffers//:flatc",
"@score_logging//score/mw/log",
"@score_baselibs//score/mw/log",
],
)

Expand Down
2 changes: 1 addition & 1 deletion src/launch_manager_daemon/lifecycle_client_lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ cc_library(
"//src/launch_manager_daemon/common:lifecycle_error",
"//src/launch_manager_daemon/common:log",
"//src/launch_manager_daemon/common:osal",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/result",
"@score_logging//score/mw/log",
],
)
2 changes: 1 addition & 1 deletion src/launch_manager_daemon/process_state_client_lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ cc_library(
"//src/launch_manager_daemon/common:identifier_hash",
"//src/launch_manager_daemon/common:lifecycle_error",
"//src/launch_manager_daemon/common:log",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/result",
"@score_logging//score/mw/log",
],
)

Expand Down
6 changes: 3 additions & 3 deletions src/lifecycle_client_lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ cc_library(
"//src/launch_manager_daemon/lifecycle_client_lib:lifecycle_client",
"@score_baselibs//score/language/futurecpp",
"@score_baselibs//score/memory:string_literal",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/os:stdlib",
"@score_baselibs//score/os/utils:signal",
"@score_logging//score/mw/log",
],
)

Expand All @@ -65,9 +65,9 @@ cc_library(
tags = ["FUSA"],
deps = [
"@score_baselibs//score/memory:string_literal",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/os:stdlib",
"@score_baselibs//score/os/utils:signal",
"@score_logging//score/mw/log",
],
)

Expand Down Expand Up @@ -117,9 +117,9 @@ cc_library(
deps = [
":application",
"//src/launch_manager_daemon/lifecycle_client_lib:lifecycle_client",
"@score_baselibs//score/mw/log",
"@score_baselibs//score/os:stdlib",
"@score_baselibs//score/os/utils:signal",
"@score_logging//score/mw/log",
],
)

Expand Down
Loading