repo: rework fix for `logging` build issues by arkjedrz · Pull Request #105 · eclipse-score/lifecycle

arkjedrz · 2026-03-04T12:19:32Z

Use logging where applicable.
Revert previous (partially invalid) change.
Fix configuration in .bazelrc.

- Use `logging` where applicable. - Revert previous (partially invalid) change. - Fix configuration in `.bazelrc`.

github-actions · 2026-03-04T12:20:30Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 2408d526-ddb4-4926-ba41-64f0de78e1d8
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (47 packages loaded, 9 targets configured)

Analyzing: target //:license-check (89 packages loaded, 9 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2096 targets configured)

Analyzing: target //:license-check (153 packages loaded, 5234 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6944 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7899 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9913 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 10039 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.738s, Critical Path: 2.71s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

arkjedrz · 2026-03-04T12:21:58Z

@ramceb
Thank You for quick reaction in previous PR. Your merge was during our internal discussion that replacing baselibs with logging is simply not a valid solution: baselibs serve as frontend, while logging provides backend.
This PR provides an expected solution - an executable is linking full logging, while libraries are linking the interface.
Hope that makes it clear.

github-actions · 2026-03-04T12:23:39Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR aims to address Bazel build issues related to score/mw/log by reworking which external Bazel module provides the logging dependency and by adjusting the .bazelrc configuration used in the repo’s standard build configs.

Changes:

Switched multiple C++ Bazel targets’ deps from @score_logging//score/mw/log to @score_baselibs//score/mw/log.
Updated .bazelrc stub config to also set KRemote_Logging=False for the @score_baselibs//score/mw/log flag target (and removed the prior global test flag line for @score_logging).
Added an explicit @score_logging//score/mw/log dep to the examples/cpp_lifecycle_app binary.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/lifecycle_client_lib/BUILD`	Swaps logging dep from `@score_logging` to `@score_baselibs`.
`src/launch_manager_daemon/process_state_client_lib/BUILD`	Swaps logging dep in `process_state_client` to `@score_baselibs`.
`src/launch_manager_daemon/lifecycle_client_lib/BUILD`	Swaps logging dep from `@score_logging` to `@score_baselibs`.
`src/launch_manager_daemon/health_monitor_lib/BUILD`	Swaps multiple logging deps from `@score_logging` to `@score_baselibs`.
`src/launch_manager_daemon/BUILD`	Swaps logging dep from `@score_logging` to `@score_baselibs`.
`src/control_client_lib/BUILD`	Swaps logging dep from `@score_logging` to `@score_baselibs`.
`examples/cpp_lifecycle_app/BUILD`	Adds explicit logging dep (currently `@score_logging//score/mw/log`).
`.bazelrc`	Moves/extends remote logging disablement for stub config to include `@score_baselibs` logging flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-04T12:24:14Z

examples/cpp_lifecycle_app/BUILD

    visibility = ["//visibility:public"],
    deps = [
        "//src/lifecycle_client_lib",
+        "@score_logging//score/mw/log",


cpp_lifecycle_app now directly depends on @score_logging//score/mw/log while //src/lifecycle_client_lib already pulls in @score_baselibs//score/mw/log transitively. Unless the example truly needs both implementations, this extra dep is likely redundant and may create inconsistent linking/flags compared to the rest of the repo. Prefer relying on the transitive dep or switching the example to the same @score_baselibs//score/mw/log target used elsewhere (whichever is intended).

Suggested change

"@score_logging//score/mw/log",

Copilot · 2026-03-04T12:24:14Z

src/launch_manager_daemon/process_state_client_lib/BUILD

    deps = [
        "//externals/ipc_dropin",
        "//src/launch_manager_daemon/common",
        "//src/launch_manager_daemon/common:identifier_hash",
        "//src/launch_manager_daemon/common:lifecycle_error",
        "//src/launch_manager_daemon/common:log",
+        "@score_baselibs//score/mw/log",
        "@score_baselibs//score/result",
-        "@score_logging//score/mw/log",
    ],


process_state_client now depends on @score_baselibs//score/mw/log, but the headers target still omits it even though the comment says its deps must match process_state_client. This can break builds that compile headers-only consumers (especially when LC_LOG_SCORE_MW_LOG is enabled) and makes the two targets diverge. Add the same @score_baselibs//score/mw/log dep to the headers rule (or adjust the comment/structure so the invariant stays true).

Copilot · 2026-03-04T12:24:15Z

src/lifecycle_client_lib/BUILD

    deps = [
        "//src/launch_manager_daemon/lifecycle_client_lib:lifecycle_client",
        "@score_baselibs//score/language/futurecpp",
        "@score_baselibs//score/memory:string_literal",
+        "@score_baselibs//score/mw/log",
        "@score_baselibs//score/os:stdlib",
        "@score_baselibs//score/os/utils:signal",


The PR description says "Use logging where applicable", but this BUILD file switches deps from @score_logging//score/mw/log to @score_baselibs//score/mw/log. At the same time, the example app adds @score_logging//score/mw/log. Please reconcile which repository should provide score/mw/log in this repo (and update either the description or the deps) to avoid inconsistent linkage/configuration across targets.

repo: rework fix for logging build issues

4dd4805

- Use `logging` where applicable. - Revert previous (partially invalid) change. - Fix configuration in `.bazelrc`.

arkjedrz requested review from Copilot, pawelrutkaq and ramceb March 4, 2026 12:19

arkjedrz self-assigned this Mar 4, 2026

arkjedrz had a problem deploying to workflow-approval March 4, 2026 12:19 — with GitHub Actions Failure

arkjedrz had a problem deploying to workflow-approval March 4, 2026 12:19 — with GitHub Actions Error

Copilot started reviewing on behalf of arkjedrz March 4, 2026 12:19 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

arkjedrz temporarily deployed to workflow-approval March 4, 2026 12:29 — with GitHub Actions Inactive

arkjedrz temporarily deployed to workflow-approval March 4, 2026 12:46 — with GitHub Actions Inactive

pawelrutkaq approved these changes Mar 4, 2026

View reviewed changes

pawelrutkaq merged commit 92eb718 into eclipse-score:main Mar 4, 2026
21 of 24 checks passed

arkjedrz deleted the arkjedrz_fix-logging-build-2 branch March 4, 2026 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repo: rework fix for `logging` build issues#105

repo: rework fix for `logging` build issues#105
pawelrutkaq merged 1 commit intoeclipse-score:mainfrom
qorix-group:arkjedrz_fix-logging-build-2

arkjedrz commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

arkjedrz commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

arkjedrz commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

License Check Results

Uh oh!

arkjedrz commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants