Skip to content

Conversation

Claudio-Chies
Copy link

@Claudio-Chies Claudio-Chies commented Sep 5, 2025

Issue:

From the Message definition of BatteryInfo and BatteryInfoAux it it not clear if a discharge current should be positive or negative, which has lead different manufacturers to implement it differently, (E.g CUAV CAN power module, reports positive current for discharging, and TATTU Smart Battery reports negative current for discharging)
The same issue for the CUAV CBAT message, no units were present for any of the fields.

Solution:

  • Added note at the end which aligns it with other dronecan messages
  • Added units to the CUAV message

Copy link

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unclear in the original definition.

@Claudio-Chies
Copy link
Author

Realized that the CBAT message suffers from the same issues, added units and definitions to it aswell.

Copy link

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting those too 👍

@Claudio-Chies
Copy link
Author

@tridge would be happy for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants