Implement ReadyToRunHelperNode for WASM - #133739
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
needs-area-label
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
| if (factory.Target.IsWasm) | ||
| { | ||
| dependencyList ??= new DependencyList(); | ||
| dependencyList.Add(factory.WasmTypeNode(this), "Wasm ReadyToRun helper signature"); | ||
| } | ||
|
|
||
| return dependencyList; |
There was a problem hiding this comment.
@copilot can we make the case in ObjectNode check for INodeWithTypeSignature instead of IMethodCodeNodeWithTypeSignature so we can have the dependency added there?
There was a problem hiding this comment.
Updated in the latest commit: ObjectNode now checks INodeWithTypeSignature and adds the WASM signature dependency centrally; the helper-specific dependency was removed.
Note
This reply was generated by GitHub Copilot.
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
| DependencyList dependencyList = null; | ||
|
|
There was a problem hiding this comment.
@copilot could you revert the changes moving around dependencyList?
There was a problem hiding this comment.
Reverted the dependencyList movement in bbfadc8a; the method now uses its original branch-local declarations and returns.
Note
This reply was generated by GitHub Copilot.
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Adds WASM code emission for ReadyToRun static-base, delegate-construction, and virtual-function helpers.
Note
This description was generated by GitHub Copilot.