Skip to content

Exclude desktop-only Security test from mobile builds #132467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidnguyen-tech wants to merge 1 commit into from
+1 −1
Closed

Exclude desktop-only Security test from mobile builds #132467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
</ItemGroup>

<!-- Compiled on desktop only: crashes Apple-mobile CoreCLR at startup due to R2R IL-body stripping. -->

@jkotas jkotas Aug 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This justification does not make sense. R2R IL-body stripping should not be stripping IL for generic instantiations.

Is this just trying to hide a real product bug in R2R?

@davidnguyen-tech davidnguyen-tech Aug 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. If it's a bug in R2R, I think we should keep #131922 opened as a KBE until it's properly fixed, instead of closing it after just disabling the failing test. This way we don't block the CI while still tracking the bug.

cc @rzikm

<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'windows' or '$(TargetPlatformIdentifier)' == 'unix' or '$(TargetPlatformIdentifier)' == 'osx'">
<ItemGroup Condition="'$(TargetsMobile)' != 'true'">
<Compile Include="SslAuthenticationOptionsTests.Desktop.cs" />
</ItemGroup>

Expand Down
Loading