Exclude desktop-only Security test from mobile builds - #132467
Exclude desktop-only Security test from mobile builds#132467davidnguyen-tech wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c120fa18-835a-418d-ae4c-d5888e699e7c
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
|
/azp run runtime Note This pipeline trigger was posted by GitHub Copilot at the user's request. |
|
/azp run runtime-extra-platforms Note This pipeline trigger was posted by GitHub Copilot at the user's request. |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull request overview
This PR updates the build condition for System.Net.Security.Unit.Tests so a desktop-only test file (SslAuthenticationOptionsTests.Desktop.cs) is excluded from mobile (and related) build legs, preventing it from being compiled where it can trigger startup failures.
Changes:
- Switch the
SslAuthenticationOptionsTests.Desktop.csCompilecondition fromTargetPlatformIdentifier-based checks toTargetsMobile-based gating. - Ensure tvOS builds (which can build this project as
net11.0-unix) still treat the build as “mobile” for exclusion purposes.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
| @@ -135,7 +135,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <!-- Compiled on desktop only: crashes Apple-mobile CoreCLR at startup due to R2R IL-body stripping. --> | |||
There was a problem hiding this comment.
This justification does not make sense. R2R IL-body stripping should not be stripping IL for generic instantiations.
Is this just trying to hide a real product bug in R2R?
Summary
SslAuthenticationOptionsTests.Desktop.csfrom all mobile buildsTargetsMobilebecause tvOS builds this project asnet11.0-unix, making the previousTargetPlatformIdentifier == 'unix'condition ineffectiveFollow-up to #131922 and #132277.
Validation
./build.sh clr+libs -rc releaseSystem.Net.Security.Unit.Tests: 134 total, 0 failed, 3 skippedSslAuthenticationOptionsTests.Desktop.cscompile inputNote
This pull request was prepared with GitHub Copilot assistance and reviewed by the submitting developer.