Skip to content

updating to address vulnerabilities #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickredondo merged 3 commits into from
Jul 24, 2025
Merged

updating to address vulnerabilities #96

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ae7fba
Update Dockerfile to use node:22-alpine and latest serve
rickredondo Jul 23, 2025
cae7bf6
Update Dockerfile to use node:22-alpine and latest serve
rickredondo Jul 23, 2025
1112fb2
Update Dockerfile to use node:22-alpine and latest serve
rickredondo Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Start your image with a node base image
FROM node:18-alpine
FROM node:22-alpine
Copy link

@Rahul-cyber26 Rahul-cyber26 Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#96 node:22-alpine


# The /app directory should act as the main application directory
WORKDIR /app
Expand All @@ -13,7 +13,7 @@ COPY ./public ./public

# Install node packages, install serve, build the app, and remove dependencies at the end
RUN npm install \
&& npm install -g serve \
&& npm install -g serve@latest \
Copy link

@Rahul-cyber26 Rahul-cyber26 Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selected line changes the installation of the global serve package to always use its latest version by specifying serve@latest instead of just serve, which would have installed the default version available at the time. This ensures that the Docker image will always have the most up-to-date version of serve when built.

&& npm run build \
&& rm -fr node_modules

Expand Down
Loading