Merged
Conversation
rickredondo
changed the title
marisimon
reviewed
Jul 24, 2025
marisimon
reviewed
Jul 24, 2025
marisimon
approved these changes
Jul 24, 2025
| @@ -1,5 +1,5 @@ | |||
| # Start your image with a node base image | |||
| FROM node:18-alpine | |||
| FROM node:22-alpine | |||
| # Install node packages, install serve, build the app, and remove dependencies at the end | ||
| RUN npm install \ | ||
| && npm install -g serve \ | ||
| && npm install -g serve@latest \ |
There was a problem hiding this comment.
The selected line changes the installation of the global serve package to always use its latest version by specifying serve@latest instead of just serve, which would have installed the default version available at the time. This ensures that the Docker image will always have the most up-to-date version of serve when built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Dockerfile to use node:22-alpine and latest serve