build: require runtime ICU data files#1998
Open
divybot wants to merge 5 commits into
Open
Conversation
Add owned aligned ICU common data storage and a file-loading helper so embedders can keep V8 i18n enabled while selecting a valid ICU .dat bundle at startup. Document the external-data GN configuration and reduced Chromium ICU bundle sizes observed during the investigation. Co-Authored-By: Divy Srivastava <me@littledivy.com>
|
|
The release aarch64-unknown-linux-gnu simdutf CI job was cancelled after hitting the existing 180 minute job timeout during the Test step. Give only that slow source-build matrix entry a 240 minute timeout while preserving the existing 180 minute limit for the rest of the matrix. Co-Authored-By: Divy Srivastava <me@littledivy.com>
Member
|
Bartek is working on this |
littledivy
reviewed
Jun 8, 2026
Set icu_use_data_file=true by default so the static library no longer embeds the ~11 MiB ICU common data. Embedders supply a valid ICU .dat package at runtime via set_common_data_77_from_file. Build with icu_use_data_file=false to opt back into linked-in ICU data.
mksnapshot must initialize ICU to generate the V8 snapshot. With icu_use_data_file=true but the icudata copy disabled, it failed with 'Failed to initialize ICU'. Enable icu_copy_icudata_to_root_build_dir and v8_depend_on_icu_data_file so mksnapshot gets a build-time copy of icudtl.dat. These only affect the build graph, not the published lib.
littledivy
changed the title
littledivy
changed the title
littledivy
enabled auto-merge (squash)
June 10, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes denoland/divybot#459