perf: embed small ICU data (flutter en+root bundle)#35040
Open
littledivy wants to merge 4 commits into
Open
Conversation
Replace the deno_core_icudata dependency (full ~10 MiB ICU common data) with Chromium's 'flutter' ICU bundle (en + root, ~0.8 MiB) vendored in tree and embedded 16-byte aligned via udata_setCommonData. Pairs with rusty_v8 building external ICU data (icu_use_data_file=true): V8 no longer links ICU data, so this embed is the sole source. Non-English locales fall back to root behavior (small-icu style); acceptable for our deployments and cuts ICU footprint by ~9 MiB.
littledivy
changed the title
# Conflicts: # Cargo.toml
littledivy
marked this pull request as ready for review
June 8, 2026 13:24
Wire the embedded flutter ICU bundle into the default build. Without this the feature was defined but never enabled, so the embed was dead code and ICU came solely from V8's linked-in data. Note: with a V8 that still links full ICU data, set_common_data overrides it with the en+root flutter bundle, so non-English Intl falls back to root until rusty_v8 ships external ICU data (icu_use_data_file=true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
deno_core_icudatadependency (full ~10 MiB ICU common data) with Chromium'sflutterICU bundle (en + root, ~0.8 MiB), vendored in-tree and embedded 16-byte aligned viaudata_setCommonData.Pairs with rusty_v8 building external ICU data (
icu_use_data_file=true, denoland/rusty_v8#1998): V8 no longer links ICU data, so this embed is the sole source.Tradeoff: non-English locales fall back to root behavior (small-icu style). Cuts ICU footprint ~9 MiB.
Draft — opened to run CI.