perf: embed small ICU data (flutter en+root bundle)

Cargo.toml

@@ -90,7 +90,6 @@ repository = "https://github.com/denoland/deno"
 
 [workspace.dependencies]
 deno_ast = { version = "=0.53.2", features = ["transpiling"] }
-deno_core_icudata = "0.77.0"
 deno_doc = "=0.199.0"
 deno_error = "=0.7.1"
 deno_graph = { version = "=0.108.4", default-features = false }

libs/core/Cargo.toml

@@ -14,9 +14,9 @@ description = "A modern JavaScript/TypeScript runtime built with V8, Rust, and T
 path = "lib.rs"
 
 [features]
-default = ["v8_use_custom_libcxx", "reactor-tokio"]
+default = ["include_icu_data", "v8_use_custom_libcxx", "reactor-tokio"]
 reactor-tokio = []
-include_icu_data = ["deno_core_icudata"]
+include_icu_data = []
 v8_use_custom_libcxx = ["v8/use_custom_libcxx"]
 v8_enable_pointer_compression = ["v8/v8_enable_pointer_compression"]
 v8_enable_v8_checks = ["v8/v8_enable_v8_checks"]
@@ -36,7 +36,6 @@ boxed_error.workspace = true
 bytes.workspace = true
 capacity_builder = "0.5.0"
 cooked-waker.workspace = true
-deno_core_icudata = { workspace = true, optional = true }
 deno_error = { workspace = true, features = ["serde_json", "serde", "url", "tokio"] }
 deno_ops.workspace = true
 deno_path_util.workspace = true

libs/core/runtime/setup.rs

@@ -144,7 +144,15 @@ fn v8_init(
 ) {
   #[cfg(feature = "include_icu_data")]
   {
-    v8::icu::set_common_data_77(deno_core_icudata::ICU_DATA).unwrap();
+    // English + root ICU data (Chromium's "flutter" bundle, ~0.8 MiB),
+    // embedded aligned to 16 bytes as required by udata_setCommonData.
+    // rusty_v8 is built with external ICU data (`icu_use_data_file=true`), so
+    // it does not link any ICU data itself; this is the data V8 uses.
+    #[repr(align(16))]
+    struct Aligned<const N: usize>([u8; N]);
+    static ICU_DATA: Aligned<{ include_bytes!("icudtl.dat").len() }> =
+      Aligned(*include_bytes!("icudtl.dat"));
+    v8::icu::set_common_data_77(&ICU_DATA.0).unwrap();
   }
 
   let base_flags = concat!(