feat: add data channel to report muted state#84
Conversation
|
@Amzd I suggest this protocol for communicating the muted state in a way other than |
|
This can work for iOS. Should be fine. Can you add more detail on why replaceTrack doesn't work? That api would still be preferred even with the datachannel since otherwise the webapp keeps sending black frames(wasting bandwidth), right? |
Yes, if
I think you mentioned that it's not nice that the last frame is being shown for a second or two after you disable the video. I will add comments in the code. |
|
Okay so replaceTrack issues:
Both of these issues are fixed by the datachannel of this PR, and replaceTrack(null) still brings the advantage of saving the bandwidth of the black frames so I think it would be nice to have both the datachannel and the replaceTrack. |
b60b1fd to
382abf8
Compare
382abf8 to
5ff2675
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Umm we just tested the |
5ff2675 to
edbe8fc
Compare
|
We have tested this MR with the iOS implementation. Works. |
This addressed the "remote video" part of #62.
TODO:
There is a blocker, see
feat: try to show avatar if remote has no video #81
I have tested this with a Desktop <-> Desktop call, and the remote's avatar is correctly shown when they enable / disable video, even if they disabled it before the call has started.
This change is backwards-compatible, i.e. the remote does not have to support this data channel and report its muted state - it's optional.