Skip to content

docs: add signaling sequence diagram#75

Merged
WofWca merged 2 commits intomainfrom
wofwca/sequence-diagram
Jan 28, 2026
Merged

docs: add signaling sequence diagram#75
WofWca merged 2 commits intomainfrom
wofwca/sequence-diagram

Conversation

@WofWca
Copy link
Copy Markdown
Member

@WofWca WofWca commented Nov 23, 2025

I heard you'd like a diagram. Let me know if this is what you wanted to see, if this clears things up.

@WofWca WofWca requested review from hpk42 and link2xt November 23, 2025 10:45
@link2xt
Copy link
Copy Markdown
Contributor

link2xt commented Nov 23, 2025

The app also uses a WebRTC data channel. What is it used for? If someone wants to switch away from this application plus webview and implement calls natively (currently happens on iOS) they need to know what happens on this data channel or can it just be ignored? In any case even if it can be ignored at the cost of e.g. worse roaming between networks, the diagram currently does not show that it is used.

@WofWca
Copy link
Copy Markdown
Member Author

WofWca commented Nov 23, 2025

I was hesitant to include this detail because apparently using a data channel for signaling is not great, i.e. we might do proper ICE trickling over email in the future. But OK, I'll include it.

Copy link
Copy Markdown

@Amzd Amzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets merge this so the proposed data channel in #84 can be added to the diagram there instead of having to update this PR again.

Copy link
Copy Markdown
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diagram is a good improvement of the docs!

I agree that the part about the data channel should be a bit more verbose but that can be improved later

Comment thread README.md Outdated
@WofWca WofWca force-pushed the wofwca/sequence-diagram branch from fba8c20 to 06411e5 Compare January 28, 2026 07:43
WofWca and others added 2 commits January 28, 2026 11:44
@WofWca WofWca force-pushed the wofwca/sequence-diagram branch from 06411e5 to 0218068 Compare January 28, 2026 07:44
@WofWca WofWca merged commit ff454f4 into main Jan 28, 2026
1 check passed
@WofWca WofWca deleted the wofwca/sequence-diagram branch January 28, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants