Skip to content

feat: try to show avatar if remote has no video#81

Merged
WofWca merged 1 commit intomainfrom
wofwca/show-avatar-if-no-video
Feb 4, 2026
Merged

feat: try to show avatar if remote has no video#81
WofWca merged 1 commit intomainfrom
wofwca/show-avatar-if-no-video

Conversation

@WofWca
Copy link
Copy Markdown
Member

@WofWca WofWca commented Jan 25, 2026

TODO:

  • Address the added TODO (see code)

Partially addresses
#62.

This only works if the remote disabled video via
replaceTrack(null), which is only utilized by
deltachat/deltachat-ios#2909
as of writing, or if the remote has no camera at all (only mic).

@WofWca WofWca force-pushed the wofwca/show-avatar-if-no-video branch 3 times, most recently from cf12719 to d3ccda2 Compare January 27, 2026 12:02
WofWca added a commit that referenced this pull request Jan 27, 2026
TODO:
- [ ] Actually use it.
  There is a blocker, see
  #81
Comment thread src/App.tsx Outdated
@WofWca WofWca changed the title feat: try to show avatar if remote has no video feat: try to show avatar if remote has no video Jan 27, 2026
@WofWca WofWca force-pushed the wofwca/show-avatar-if-no-video branch from 0b01aa2 to af7f2a5 Compare February 4, 2026 11:55
@WofWca WofWca marked this pull request as ready for review February 4, 2026 12:02
Partially addresses
#62.

This only works if the remote disabled video via
`replaceTrack(null)`, which is only utilized by
deltachat/deltachat-ios#2909
as of writing, or if the remote has no camera at all (only mic).

Co-authored-by: adb <adb@merlinux.eu>
@WofWca WofWca force-pushed the wofwca/show-avatar-if-no-video branch from af7f2a5 to 74f9d25 Compare February 4, 2026 12:13
Copy link
Copy Markdown

@Amzd Amzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @adbenitez should confirm too

@WofWca
Copy link
Copy Markdown
Member Author

WofWca commented Feb 4, 2026

A way to test this: plug off the caller's camera (leaving only the mic), or make some other app start using the camera, so that the caller's app doesn't have access to it.

Copy link
Copy Markdown
Member

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WofWca WofWca merged commit 481f543 into main Feb 4, 2026
1 check passed
@WofWca WofWca deleted the wofwca/show-avatar-if-no-video branch February 4, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants