Skip to content

Perlin noise#3

Merged
falkecarlsen merged 26 commits intomasterfrom
perlin
Mar 19, 2020
Merged

Perlin noise#3
falkecarlsen merged 26 commits intomasterfrom
perlin

Conversation

@falkecarlsen
Copy link
Member

@falkecarlsen falkecarlsen commented Mar 18, 2020

  • Find good lib for generating Perlin noise
  • Use sumolib for more easily manipulating SUMO network
  • Iterate over every edge-pair in network
  • For each edge-pair apply perlin-noise dictated population proportional to stat-population
  • Apply offset to Perlin noise generator to avoid (0,0) = 0 result
  • Write unit-tests

Unit-tests and further work is delegated to later PRs as this is needed on master.

@falkecarlsen falkecarlsen added the enhancement New feature or request label Mar 19, 2020
@falkecarlsen falkecarlsen marked this pull request as ready for review March 19, 2020 12:46
Copy link
Contributor

@NicEastvillage NicEastvillage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additions are good but the PR seems unfinished. By that I don't mean unit testing, but a thourough clean up to make things more readable. Too many functions are just simple expressions that could be inlined.

Additionally, your provided perlin simplex noise function does consider scale, octaves, lucanarity, or persistance. We should find some good values for those either at calling site or as parameters to the whole tool.

@falkecarlsen
Copy link
Member Author

Turns out that 'noise' does not support seeding but a stale PR exists which fixes this: caseman/noise#22.

Realistically, in this stage of development, simply offsetting and/or scaling would suffice as the resolution in 'noise' is very large.

Copy link
Contributor

@NicEastvillage NicEastvillage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Now that is better. I agree with your comments regarding #4, but it should be one of the next things we do.

@falkecarlsen falkecarlsen merged commit db2d565 into master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants