Skip to content

Add example network which can be used for testing#2

Merged
NicEastvillage merged 6 commits intomasterfrom
test-network
Mar 19, 2020
Merged

Add example network which can be used for testing#2
NicEastvillage merged 6 commits intomasterfrom
test-network

Conversation

@NicEastvillage
Copy link
Contributor

Adds example network which can be used for testing. Also includes a very small script for generating new random networks. Changes to the examples are ignored per default.

@NicEastvillage NicEastvillage added the documentation Improvements or additions to documentation label Mar 18, 2020
Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but example networks collide with #3.
I suggest keeping example.net.xml as that's shared but removing (git rm) example.stat.xml as #3 holds a modified version of it.

@NicEastvillage
Copy link
Contributor Author

Sounds like a #3's problem. But went ahead and did it anyway.

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a #3's problem. But went ahead and did it anyway.

Well, neither has been merged so it's a potential problem for both.

@NicEastvillage NicEastvillage merged commit 68659b6 into master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants