Make Problem.bounds and .eom_bounds properties. #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The test of #464 will , rightly!, no longer work. |
Member
Author
|
Yeh, sorry. But I didn't want to encode things in the tests that shouldn't be supported. |
Contributor
|
I 100% agree! My test was wrong. I just wanted to remind you as I cannot right now correct it. |
Contributor
|
In direct_collocation.py would we have to change in lines 340, 346, 358 self.eom_bounds to self._eom_bounds, etc? |
Member
Author
|
You can access the variable you just can't set it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set the bounds or eom_bounds now, it is not actually setting them on the underlying Problem machinery. So we make them properties so they cannot be set (for now).
To make them settable we need to address the issue #418 and PR #421.