Skip to content

Wait for window.monacoEditorInstances #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianjhanson wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Wait for window.monacoEditorInstances #429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd809c
Wait for window.monacoEditorInstances
brianjhanson Jun 4, 2025
44c6e6c
Merge branch '5.x' into bugfix/monaco-editor-instances
i-just Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 40 additions & 24 deletions src/templates/cke-configs/_edit.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,30 +186,46 @@
{% endblock %}
{% endembed %}

{% script with {type: 'module'} %}
import {ConfigOptions, ToolbarBuilder} from '@craftcms/ckeditor-config';
{{ importStatements|raw }}

const configOptions = new ConfigOptions("{{ configOptionsId }}", "{{ jsonSchemaUri }}");
new ToolbarBuilder("{{ toolbarBuilderId }}", "{{ containerId }}", configOptions, [{{ plugins | join(',') }}]);

(() => {
// Register the config options JSON schema
const jsonSchemaUri = {{ jsonSchemaUri|json_encode|raw }};
const schema = JSON.parse(JSON.stringify({{jsonSchema|json_encode|raw}}));

monaco.languages.json.jsonDefaults.setDiagnosticsOptions({
validate: true,
schemas: [
{
uri: jsonSchemaUri,
fileMatch: [jsonSchemaUri],
schema: schema,
},
],
});
})()
{% endscript %}
<script type="module">
import {ConfigOptions, ToolbarBuilder} from '@craftcms/ckeditor-config';
{{ importStatements|raw }}

function initializeConfig() {
const configOptions = new ConfigOptions("{{ configOptionsId }}", "{{ jsonSchemaUri }}");
new ToolbarBuilder("{{ toolbarBuilderId }}", "{{ containerId }}", configOptions, [{{ plugins | join(',') }}]);

(() => {
// Register the config options JSON schema
const jsonSchemaUri = {{ jsonSchemaUri|json_encode|raw }};
const schema = JSON.parse(JSON.stringify({{ jsonSchema|json_encode|raw }}));

monaco.languages.json.jsonDefaults.setDiagnosticsOptions({
validate: true,
schemas: [
{
uri: jsonSchemaUri,
fileMatch: [jsonSchemaUri],
schema: schema,
},
],
});
})();
}

/**
* This is not ideal, but when loading the config in a slideout (seemingly only in FireFox)
* this module code can run `window.monacoEditorInstances` has been created.
*/
function checkWindow() {
if (typeof window.monacoEditorInstances === 'undefined') {
setTimeout(checkWindow, 100);
} else {
initializeConfig();
}
}

checkWindow();
</script>

{{ codeEditor.textareaField(
{
Expand Down
Loading