Wait for window.monacoEditorInstances #429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think ideally we'd instantiate the monaco editor ourselves, but even then we'd have to wait for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this a draft because I'd like to find a better, fix but also don't want to lose this in case this ends up being the best option.
When loading a CKEditor config in a slideout, sometimes (potentially only in Firefox) the module script in
_edit.twigcan be executed beforewindow.makeMonacoEditorhas been called and thewindow.monacoEditorInstancesobject established. In those cases, you'll get awindow.monacoEditorInstances is undefinedtype error, and the config editor won't load.