Fix CI Suite, support circleci stanza, other fixes #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support new CircleCI stanza for Catalog Entities
Pull in upstream changes
akwirick
approved these changes
Apr 16, 2025
| @@ -53,7 +53,6 @@ resource %[1]q %[2]q { | |||
| ] | |||
| } | |||
| filter = { | |||
| category = "SERVICE" | |||
There was a problem hiding this comment.
Thanks for removing this. I can file an internal bug to get the provider updated to support include/exclude types (which is what replaced category).
|
@splittingred I opened #47 to figure out how we are gonna tackle the CI issues here. I'm leaning towards just merging your PR and then fixing it up on our side with changes so that the acceptance tests only run on the main branch. Feel free to comment on that issue if you've got feedback on either approach. I'm also running this by our internal team. |
akwirick
added a commit
that referenced
this pull request
Apr 18, 2025
This was addressed in #45 but regressed in #46 after changes to the acceptance testing flow. Category is deprecated in the Cortex API and the provider will need an update to adopt the newer filtering approach. In the meantime, we just remove the feature from acceptance testing and mark it as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following:
x-cortex-circle-ciin catalog entitiestenvlinter which is deprecatedfilter.category(which doesnt exist anymore in Cortex API - fixing this in TF provider will need seperate work)I am assuming the CI suite wont pass because I'm not granted GH secrets access to
CORTEX_API_TOKEN. You can see these changes working in our fork (which uses the same Cortex workspace for the CI suite), anyway: https://github.com/bigcommerce/terraform-provider-cortex/actions/runs/13866159540/job/38805627263