Skip to content

CI - Acceptance testing only works on pull requests coming from cortexapps #47

Closed
@akwirick

Description

@akwirick

Community submitted PRs such as #45 will always fail the acceptance testing because the CORTEX_API_TOKEN secret will not be used in their request. We've got a couple options for handling this.

First, we could shift the CI runs to allow PRs without acceptance tests to be submitted. Upon merge to main we'd need to run acceptance tests and this would block a release. The advantage here is that community submissions would be easier, but if they break acceptance tests it would be on Maintainers to fix them before a release can be cut.

Second, we could leave things alone and disallow forked contributions. The downside here is that this would restrict PRs to only originating from cortexapps branches, which obviously limits community involvement.

I'm personally leaning towards Option 1 since that encourages community PRs but want to talk with Cortex folks internally before I make a call on this. Also happy to get feedback from the community.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions