Repository navigation
refactor: breakage-suite.yml decisions in tested scripts - #172
Merged
Merged
Conversation
….jl) The cell (which ref to test, the test or doc run, the cell file) moves to scripts/breakage/cell.jl; the pull request facts, the baseline run on the base commit and the comment kept by marker move to pr.jl, on scripts/shared/github.jl; report.jl reads the two versions itself (--base-sha) instead of sed. Inline shell goes from about 102 lines to 24, all wiring. The cell file is written with TOML.print, so a value is quoted correctly. A failed clone now fails the job instead of testing the wrong directory. Refs #161. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
Member
Author
|
Tested in a real package: throwaway draft PR CTBase.jl#654 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of #161 (after
update-readme.yml, #167).scripts/breakage/cell.jl: one cell — clone, pick the ref (latest= default branch,stable= newestv*tag, else the given ref), run the tests or the docs with the package under test developed, read the resolved version, write the cell file withTOML.print(the heredoc did not quote values).scripts/breakage/pr.jl:facts(base, fork),baseline(the newest completed non-PR run on the base commit, its artifact),comment(update the comment that starts with the group's marker, or create it). Replaces thegh apishell and thegithub-scriptstep; usesscripts/shared/github.jlandreport.jl'smarker.report.jl --base-sha SHA: reads both versions with TOML instead ofsed.Behaviour changes, both deliberate:
cd repofailed silently and the step went on in the wrong directory.repo/in the workspace.Checked:
--base-shaon a real git repo, 68 consumers, 22 cell, 20 pr);actionlintclean.pr.jl factsandpr.jl baselineon CTBase.jl PR #653 (base found, the push run'sbreakage-packagesartifact downloaded).stable→v0.3.1, tests pass, compatv0.30.13(5 min).Breakage.ymlcallsbreakage-suite.yml@refactor/breakage-suite-shellwithctactions_ref: refactor/breakage-suite-shell, then the labelrun breakage(ctactions_refalone moves only the scripts, not the workflow file).🤖 Generated with Claude Code