Skip to content

refactor: release.yml pending approvals in release.jl pending - #173

Merged
ocots merged 1 commit into
mainfrom
refactor/release-shell
Nov 14, 2026
Merged

ocots merged 1 commit into
mainfrom
refactor/release-shell

Conversation

@ocots

@ocots ocots commented Nov 13, 2026

Copy link
Copy Markdown
Member

Last step of #161, on top of #172 (base: its branch; GitHub retargets to main once #172 is merged).

  • scripts/release/pending.jl + release.jl pending: the "Pending approvals" step of release.yml (which job carries the next action, the waiting runs of the same workflow, skip when one already waits for that job, cancel the others). Same behaviour as the shell; a run that disappeared between the listing and the cancel is ignored as before.
  • 13 new tests in scripts/release/test/runtests.jl (workflow path from github.workflow_ref, job mapping incl. register-beta, caller / job names, this run never cancelled, GitHub not answering, the GITHUB_OUTPUT line, usage). Full release suite green locally (1037944).
  • Kept inline on purpose (documented in principles.md): the open [RELEASE] issue check (one gh call that ends most runs before Julia is set up), the bot's git identity and the wake-up (wiring). Inline shell: 32 lines.
  • Docs: release-cli.md (pending, never by hand: it cancels runs), release.md, principles.md (Long inline shell in workflows: move what decides into tested scripts #161 exceptions cleared).
  • Not run against a real repository: pending cancels runs. First real use: the next release.

Closes #161.

🤖 Generated with Claude Code

The step that keeps one approval at a time (skip when another run already waits for
the same job, cancel the runs waiting for another) moves from shell to
scripts/release/pending.jl, with tests. What stays inline in release.yml is wiring,
and the open-issue check that ends most runs before Julia is set up. Closes #161.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from refactor/breakage-suite-shell to main November 14, 2026 11:41
@ocots
ocots merged commit 978a632 into main Nov 14, 2026
4 checks passed
@ocots
ocots deleted the refactor/release-shell branch November 14, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long inline shell in workflows: move what decides into tested scripts

1 participant