Repository navigation
refactor: release.yml pending approvals in release.jl pending - #173
Merged
Merged
Conversation
The step that keeps one approval at a time (skip when another run already waits for the same job, cancel the runs waiting for another) moves from shell to scripts/release/pending.jl, with tests. What stays inline in release.yml is wiring, and the open-issue check that ends most runs before Julia is set up. Closes #161. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last step of #161, on top of #172 (base: its branch; GitHub retargets to
mainonce #172 is merged).scripts/release/pending.jl+release.jl pending: the "Pending approvals" step ofrelease.yml(which job carries the next action, the waiting runs of the same workflow, skip when one already waits for that job, cancel the others). Same behaviour as the shell; a run that disappeared between the listing and the cancel is ignored as before.scripts/release/test/runtests.jl(workflow path fromgithub.workflow_ref, job mapping incl.register-beta,caller / jobnames, this run never cancelled, GitHub not answering, theGITHUB_OUTPUTline, usage). Full release suite green locally (1037944).principles.md): the open[RELEASE]issue check (oneghcall that ends most runs before Julia is set up), the bot's git identity and the wake-up (wiring). Inline shell: 32 lines.pending, never by hand: it cancels runs), release.md, principles.md (Long inline shell in workflows: move what decides into tested scripts #161 exceptions cleared).pendingcancels runs. First real use: the next release.Closes #161.
🤖 Generated with Claude Code