Skip to content

chore: regenerate crapload baseline for latest gaze version#471

Merged
hbraswelrh merged 2 commits intocomplytime:mainfrom
hbraswelrh:chore/update-crapload-baseline
Apr 14, 2026
Merged

chore: regenerate crapload baseline for latest gaze version#471
hbraswelrh merged 2 commits intocomplytime:mainfrom
hbraswelrh:chore/update-crapload-baseline

Conversation

@hbraswelrh
Copy link
Copy Markdown
Member

@hbraswelrh hbraswelrh commented Apr 13, 2026

Summary

  • Regenerates .gaze/baseline.json to include up-to-date GazeCRAP scores
  • The previous baseline was generated with an older gaze version that did not compute GazeCRAP, storing None/0 for all functions
  • This caused false positive regressions in CI (e.g., FormatScanSummary GazeCRAP 0 → 9) on any PR, regardless of code changes

Test plan

  • CRAP Load Check CI passes without false regressions
  • Run make crapload-check locally and verify no regressions are reported
  • Run make crapload locally and verify the text output matches the updated baseline scores

🤖 Generated with Claude Code

@hbraswelrh hbraswelrh requested a review from a team as a code owner April 13, 2026 08:27
The baseline had stale GazeCRAP scores (None/0) from an older gaze
version. Regenerating updates all scores so CI no longer flags false
regressions on functions like FormatScanSummary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
@hbraswelrh hbraswelrh force-pushed the chore/update-crapload-baseline branch from 8d19a16 to d02f591 Compare April 13, 2026 08:29
Copy link
Copy Markdown
Contributor

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — CI is green and the baseline regeneration correctly addresses the stale GazeCRAP scores.

One note for awareness: The new recommended_actions section contains 20 entries with absolute file paths from the generating machine (e.g., /Users/hbraswel/github/complytime/complyctl/cmd/...). The scores, worst_crap, and worst_gaze_crap sections correctly use relative paths.

This is a gaze upstream issue — the newer version emits absolute paths in recommended_actions because Score.File is populated from gocyclo.Stat.Pos.Filename (which uses the absolute walk root) and no relativization was applied before building the summary.

A fix has been proposed upstream in gaze to relativize all Score.File paths against the module root after computeScores() returns. Once that fix lands, regenerating the baseline will produce relative paths everywhere.

Not a blocker for this PR.

Line numbers shifted in cmd/behavioral-report/main.go after upstream
main updates. Regenerated baseline to reflect current state.

Signed-off-by: Hannah Braswell <hbraswelrh@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbraswelrh hbraswelrh enabled auto-merge (squash) April 13, 2026 22:04
Copy link
Copy Markdown
Member

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbraswelrh hbraswelrh merged commit e7abb17 into complytime:main Apr 14, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants