feat: migrates go-gemara from v0.0.1 to v0.3.0#472
Merged
hbraswelrh merged 10 commits intocomplytime:mainfrom Apr 14, 2026
Merged
feat: migrates go-gemara from v0.0.1 to v0.3.0#472hbraswelrh merged 10 commits intocomplytime:mainfrom
hbraswelrh merged 10 commits intocomplytime:mainfrom
Conversation
Member
Author
|
/packit build |
4 tasks
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Updates the vendored go-gemara dependency to v0.3.0 and aligns governance artifact gemara-version fields from 1.0.0-rc.2 to 1.0.0 to match the GA schema release. Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hbraswelrh
force-pushed
the
feat/migrates-gemara-v0.3.0
branch
from
e942351 to
cf78621
Compare
Adds tests covering manifest fetch, JSON parse, and layer matching to bring LoadLayerByMediaType coverage from guard-clauses-only to 82.4%, resolving the CRAPLoad new-function violation (58.78 → below threshold). Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
marcusburghardt
previously approved these changes
Apr 14, 2026
Contributor
marcusburghardt
left a comment
marcusburghardt
left a comment
There was a problem hiding this comment.
AI-assisted review: APPROVE — All CI checks pass. Two LOW non-blocking observations noted inline.
jpower432
reviewed
Apr 14, 2026
- Adds comment explaining Undetermined as conservative default for unknown plugin confidence levels - Updates ampel-branch-protection-catalog gemara-version to 1.0.0 Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hbraswelrh
dismissed stale reviews from jpower432 and marcusburghardt
via
5f6d130
Member
Author
|
@marcusburghardt @jpower432 Factored in review comments. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/gemaraproj/go-gemarafrom v0.0.1 to v0.3.0 (Gemara spec v1.0.0 GA)gemara.Load[T]()with fetcher interface, renamed enum values (NotSet→Undetermined), and updatedAcceptedMethodfields (Type→Mode)governance/capabilities/complytime-capabilities.yamlwith 7 capabilities extracted from the threat catalogRelated Issues
Security review
go mod verify— all modules verified)EntryMapping.ReferenceIdfield tag removesomitempty(v0.3.0 change) — strictness improvement that prevents ambiguous empty reference-id values from being silently dropped during serializationRelated Issues
Test plan
go build ./...passesgo test ./internal/output/ ./internal/policy/passesgo mod verify— all modules verifiedLoadLayerByMediaTypecoverage raised to 82.4% (CRAPLoad new-function violation resolved)🤖 Generated with Claude Code