-
Notifications
You must be signed in to change notification settings - Fork 10.1k
basic jotpluggler #36045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic jotpluggler #36045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine! I did a quick pass at the review, but at first glance, I think there's some premature abstraction here.
I suggest doing a couple rounds of review with ChatGPT or similar to simplify this is a bit. It's very much worth doing now as everything will be built on top of this.
I tried properly expanding all the log data (log_time_series doesn't expand lists) and the number of fields goes from ~950 to ~13500 which makes a lot of things really slow. Building up the the proclog dropdown with the ~600 dropdowns takes several seconds, so I'll definitely have to change all of that. The fully expanded log data code is here: https://github.com/commaai/openpilot/tree/jotpluggler2 |
i might have made it messier before I make it cleaner but a 60 segment route now loads in 28 seconds and uses ~2GB of memory |
Just got this:
Can we fix it so we don't need to install another package? |
e1ec4b1
to
de10b64
Compare
not sure where this is coming from, I apt removed python3-tk and it still works fine for me, the error is from pyautogui but the part of pyautogui I'm using shouldn't be using MouseInfo |
missing quite a few features, may have some slight bugs
working: