Skip to content

Conversation

Quantizr
Copy link
Contributor

missing quite a few features, may have some slight bugs

working:

  • loading routes (merging routes when processing them in parallel had some bug so I removed that for now)
  • timeline
  • sidebar showing all log messages
  • drag and drop from sidebar
  • split graph into multiple graphs

Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine! I did a quick pass at the review, but at first glance, I think there's some premature abstraction here.

I suggest doing a couple rounds of review with ChatGPT or similar to simplify this is a bit. It's very much worth doing now as everything will be built on top of this.

@Quantizr
Copy link
Contributor Author

I tried properly expanding all the log data (log_time_series doesn't expand lists) and the number of fields goes from ~950 to ~13500 which makes a lot of things really slow. Building up the the proclog dropdown with the ~600 dropdowns takes several seconds, so I'll definitely have to change all of that. The fully expanded log data code is here: https://github.com/commaai/openpilot/tree/jotpluggler2

@Quantizr
Copy link
Contributor Author

Quantizr commented Aug 27, 2025

i might have made it messier before I make it cleaner but a 60 segment route now loads in 28 seconds and uses ~2GB of memory
unfortunately a single segment route still takes 6 seconds...

@adeebshihadeh
Copy link
Contributor

Just got this:

(openpilot) batman@workstation-adeeb2:~/openpilot/tools/jotpluggler$ ./pluggle.py -h
NOTE: You must install tkinter on Linux to use MouseInfo. Run the following: sudo apt-get install python3-tk python3-dev

Can we fix it so we don't need to install another package?

@Quantizr
Copy link
Contributor Author

Quantizr commented Sep 6, 2025

Just got this:

(openpilot) batman@workstation-adeeb2:~/openpilot/tools/jotpluggler$ ./pluggle.py -h
NOTE: You must install tkinter on Linux to use MouseInfo. Run the following: sudo apt-get install python3-tk python3-dev

Can we fix it so we don't need to install another package?

not sure where this is coming from, I apt removed python3-tk and it still works fine for me, the error is from pyautogui but the part of pyautogui I'm using shouldn't be using MouseInfo

@adeebshihadeh adeebshihadeh marked this pull request as ready for review September 9, 2025 17:56
@adeebshihadeh adeebshihadeh merged commit ea53111 into master Sep 9, 2025
11 checks passed
@adeebshihadeh adeebshihadeh deleted the jotpluggler branch September 9, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants