Skip to content

[Code Cleanup] from #10233#12148

Open
Venuska1117 wants to merge 4 commits intocmss13-devs:masterfrom
Venuska1117:cleanup-burrower-imp
Open

[Code Cleanup] from #10233#12148
Venuska1117 wants to merge 4 commits intocmss13-devs:masterfrom
Venuska1117:cleanup-burrower-imp

Conversation

@Venuska1117
Copy link
Copy Markdown
Contributor

@Venuska1117 Venuska1117 commented Apr 23, 2026

About the pull request

Cleanup single letter vars and try to use mostly snake_case

Explain why it's good for the game

Required to cleanup #10233 size and generally better code visibility and readibility.

Made sure twice that #10233 changes are NOT carried in this cleanup.

Testing Photographs and Procedure

Launched private instance and didnt get errors.

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Apr 23, 2026
@cmss13-ci cmss13-ci Bot added Missing Changelog Maintainers always document their changes. size/L Denotes a PR that changes 200-799 lines, ignoring generated files. labels Apr 23, 2026
Venuska1117 added 2 commits April 23, 2026 14:21
@Venuska1117 Venuska1117 changed the title [Cleanup] for #10233 [Cleanup] from #10233 Apr 23, 2026
@Venuska1117 Venuska1117 changed the title [Cleanup] from #10233 [Code Cleanup] from #10233 Apr 23, 2026
@cuberound
Copy link
Copy Markdown
Contributor

cuberound commented Apr 24, 2026

just var renames and delted spaces in if, looks fine

Copy link
Copy Markdown
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope but there are bad deletes / race conditions everywhere 😭

Comment thread code/modules/cm_aliens/structures/trap.dm Outdated
@Venuska1117 Venuska1117 force-pushed the cleanup-burrower-imp branch from c781b37 to b121d96 Compare May 5, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Missing Changelog Maintainers always document their changes. size/L Denotes a PR that changes 200-799 lines, ignoring generated files.

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

3 participants