[Code Cleanup] from #10233#12148
Open
Venuska1117 wants to merge 4 commits intocmss13-devs:masterfrom
Open
Conversation
1 task
added 2 commits
April 23, 2026 14:21
Contributor
|
just var renames and delted spaces in if, looks fine |
fira
reviewed
May 5, 2026
Member
fira
left a comment
There was a problem hiding this comment.
out of scope but there are bad deletes / race conditions everywhere 😭
c781b37 to
b121d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Cleanup single letter vars and try to use mostly snake_case
Explain why it's good for the game
Required to cleanup #10233 size and generally better code visibility and readibility.
Made sure twice that #10233 changes are NOT carried in this cleanup.
Testing Photographs and Procedure
Launched private instance and didnt get errors.