Ensure package_create resources trigger XLoader submission for datastore and views

[TomeCirun]

When we harvest a dataset, we call the create_or_update_package function or use package_create with resources. All resources are included inside package_dict, so they aren’t created separately — resource_create is never called. As a result, the xloader hook isn’t triggered, resources aren’t pushed to the datastore, and their default views aren’t created.

To resolve this, I removed the after_resource_create hook and now handle everything within notify.

[ThrawnCA]

What about changing the Data Dictionary? Or the resource format? Or removing a schema?

[TomeCirun]

Hi @ThrawnCA , thanks for taking the time to review this PR — I really appreciate it. Could you please clarify what the expected output should be? Just to note, this line was copied from the previous logic, so it remains as originally implemented.

[ThrawnCA]

Hmm. You're right that the logic did include this before. But are you also going to replace after_resource_update, which doesn't include that restriction and applies XLoader to any update?

[TomeCirun]

I forgot about that — sorry, and thanks for pointing it out! I’ll update the PR soon.

[TomeCirun]

Hi @ThrawnCA

I moved the logic into a separate function sync_datastore_flag and we now call it inside this check:

if not getattr(entity, 'url_changed', False):

This reduces redundant calls. If the URL has changed, _submit_to_xloader will set the flag on the resource. I also removed the after_resource_update hook.

Please let me know if there’s anything else I should address.

[ThrawnCA]

There are other fields that should potentially trigger XLoader on change, such as the resource format.