Handle new and changed resources in notify method#268
Closed
bellisk wants to merge 1 commit intockan:masterfrom
Closed
Handle new and changed resources in notify method#268bellisk wants to merge 1 commit intockan:masterfrom
bellisk wants to merge 1 commit intockan:masterfrom
Conversation
This change moves submission of a resource to xloader into the notify method for new resources, as well as changed ones. It also removes the method after_resource_create, which is no longer needed. This ensures that resources are submitted to xloader when they are created *without* calling the resource_create action - for example, when datasets are created by harvesting. It also simplifies the plugin logic.
Contributor
Author
|
Ah, I see this duplicates @TomeCirun's PR #265, so I'll close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves submission of a resource to xloader into the notify method for new resources, as well as changed ones. It also removes the method after_resource_create, which is no longer needed.
This ensures that resources are submitted to xloader when they are created without calling the resource_create action - for example, when datasets are created by harvesting. It also simplifies the plugin logic.