Skip to content

Conversation

@johnmccrae
Copy link
Contributor

@johnmccrae johnmccrae commented Oct 15, 2025

Starting in Ruby 3.4, we get warnings about frozen strings being literals. In the past, we would need to add the magic comment: "# frozen_string_literal: true". What that warning tells us is that we have code that is treating immutable strings as mutable.
Also cookstyle has us remove ".freeze" to other files as well.

Ruby Docs - that doc links to how/why we need to do this work.

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae johnmccrae requested review from a team and jaymzh as code owners October 15, 2025 21:34
@sonarqubecloud
Copy link

@johnmccrae johnmccrae merged commit e4c11ce into main Oct 16, 2025
32 checks passed
@johnmccrae johnmccrae changed the title adding a tweaks for stirng freezes adding a tweaks for string freezes Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants