adding a tweaks for stirng freezes (#272)

* adding a tweaks for stirng freezes
Signed-off-by: John McCrae <[email protected]>

Author: johnmccrae

Rakefile

@@ -22,4 +22,20 @@ task :console do
   IRB.start
 end
 
-task default: %i{spec}
+task default: %i{style spec}
+
+desc "Check Linting and code style."
+task :style do
+  require "rubocop/rake_task"
+  require "cookstyle/chefstyle"
+
+  if RbConfig::CONFIG["host_os"] =~ /mswin|mingw|cygwin/
+    # Windows-specific command, rubocop erroneously reports the CRLF in each file which is removed when your PR is uploaeded to GitHub.
+    # This is a workaround to ignore the CRLF from the files before running cookstyle.
+    sh "cookstyle --chefstyle -c .rubocop.yml --except Layout/EndOfLine"
+  else
+    sh "cookstyle --chefstyle -c .rubocop.yml"
+  end
+rescue LoadError
+  puts "Rubocop or Cookstyle gems are not installed. bundle install first to make sure all dependencies are installed."
+end

lib/mixlib/shellout.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #--
 # Author:: Daniel DeLeo (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.
@@ -239,7 +240,7 @@ def timeout
     def format_for_exception
       return "Command execution failed. STDOUT/STDERR suppressed for sensitive resource" if sensitive
 
-      msg = ""
+      msg = String.new
       msg << "#{@terminate_reason}\n" if @terminate_reason
       msg << "---- Begin output of #{command} ----\n"
       msg << "STDOUT: #{stdout.strip}\n"
@@ -269,7 +270,9 @@ def exitstatus
     #   within +timeout+ seconds (default: 600s)
     def run_command
       if logger
-        log_message = (log_tag.nil? ? "" : "#{@log_tag} ") << "sh(#{@command})"
+        prefix = log_tag.nil? ? "" : "#{@log_tag} "
+        log_message = prefix + "sh(#{@command})"
+        # log_message = (log_tag.nil? ? "" : "#{@log_tag} ") << "sh(#{@command})"
         logger.send(log_level, log_message)
       end
       super

lib/mixlib/shellout/unix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Daniel DeLeo (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.