chore!: undeprecate v2 upgrade height #6197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
cmwaters,
evan-forbes,
ninabarbakadze and
rach-id
as code owners
ninabarbakadze
approved these changes
Nov 13, 2025
rach-id
reviewed
Nov 14, 2025
Member
rach-id
left a comment
rach-id
left a comment
There was a problem hiding this comment.
This change is breaking. Not sure if we should merge it now or wait for a major release 🤔
rootulp
changed the title
Collaborator
Author
|
Agreed it is breaking so will hold off on merging for now. |
rootulp
added
warn:api breaking
Member
afaiu we're just waiting to cut v6.x, right? |
Collaborator
Author
Yes. IMO we shouldn't do that until we need to merge changes that are breaking (i.e. can't be merged to main). Likely sometime after v6 activation height on Mainnet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6177 I realized it is cumbersome to set the
--v2-upgrade-heightvia ldflags.This change reverts the deprecation for the
--v2-upgrade-height. If a user passes the--v2-upgrade-heightto the multiplexer, it forwards that to the embedded binaries.Note for reviewers: we don't strictly need this change.
Testing