Skip to content

fix(multiplexer): v2 upgrade height #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

fix(multiplexer): v2 upgrade height #6202

merged 1 commit into from
Nov 17, 2025

Conversation

@rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 14, 2025 •
edited
Loading

Closes #6177

The multiplexer was setting the v2 upgrade height to 0.

Short term: this PR adds a check to only append the --v2-upgrade-height flag if it isn't set to 0.

Long term: remove the ldflags entirely in #6197

@rootulp rootulp self-assigned this Nov 14, 2025
rach-id
rach-id approved these changes Nov 15, 2025
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great debugging. Was this tested on Chris's node?

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 15, 2025

Was this tested on Chris's node?

Sadly no. I verified this fixes the e2e test.

But I can't explain why Chris's node that was running celestia-app v3.x (without multiplexer) still can't sync through the v2 upgrade height. This change wouldn't fix that issue because this fixes the multiplexer, not the v3.x binary.

@rach-id
Copy link
Member

rach-id commented Nov 16, 2025

But I can't explain why Chris's node that was running celestia-app v3.x (without multiplexer) still can't sync through the v2 upgrade height. This change wouldn't fix that issue because this fixes the multiplexer, not the v3.x binary.

would we be able to to try and sync a node from genesis using the v6 binary and see if it works? to confirm the issue is gone

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 16, 2025

Yes agreed. @pippokr can we please run this version on one of the Arabica snapshot nodes?

@rootulp rootulp added this pull request to the merge queue Nov 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2025
@rootulp rootulp added this pull request to the merge queue Nov 17, 2025
Merged via the queue into celestiaorg:main with commit f16b099 Nov 17, 2025
44 checks passed
@rootulp rootulp deleted the rp/fix-multiplexer-v2 branch November 17, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@ninabarbakadze ninabarbakadze ninabarbakadze approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters cmwaters is a code owner

Assignees

@rootulp rootulp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wrong Block.Header.Version. Expected {11 1}, got {11 2}

4 participants

@rootulp @rach-id @evan-forbes @ninabarbakadze