Switch docker compose to use pre-built docker images#1659
Merged
austinabell merged 9 commits intorelease-1.2from Feb 20, 2026
Merged
Switch docker compose to use pre-built docker images#1659austinabell merged 9 commits intorelease-1.2from
austinabell merged 9 commits intorelease-1.2from
Conversation
austinabell
requested review from
a team,
Wollac,
capossele,
ec2,
willemolding and
zeroecco
as code owners
capossele
reviewed
Feb 18, 2026
| build-bento: | ||
| name: Build Bento Components | ||
| runs-on: [ self-hosted, prod, "Linux", "cpu" ] | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
Is this intentional to keep on ubuntu-latest?
Contributor
Author
There was a problem hiding this comment.
yes, the ami we were using is currently broken for building bento
capossele
approved these changes
Feb 18, 2026
zeroecco
approved these changes
Feb 19, 2026
Contributor
zeroecco
left a comment
zeroecco
left a comment
There was a problem hiding this comment.
approved. Only thing to note here is how the image is built. ptxas can't cross compile newer -> older. If a user is on cuda 12.8 and needs to cross compile to a sm_code we do not support in the container AND we compile on cuda 12.9 the binary will not work for that user.
austinabell
added a commit
that referenced
this pull request
Feb 20, 2026
The pattern will be that for `release-x` branches, we will constrain the prebuilt docker images to use latest minor version, and then for main when this gets backported, will switch that version to `latest`. `latest` overriden for every new release, `release-x.x` updated whenever new patch versions of that specific maj/min are published. We just need to constrain that patch releases don't contain breaking changes with this, otherwise we will need to specify speciifc patch versions on the version used by default (not ideal). Other: - CI release action switched to gh because old was deprecated and broken - Build pre-built docker images, switch default to use those images - When specifying `BOUNDLESS_BUILD=...`, the binaries that are specified are build from source, using pre-built native binaries no longer used by default
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern will be that for
release-xbranches, we will constrain the prebuilt docker images to use latest minor version, and then for main when this gets backported, will switch that version tolatest.latestoverriden for every new release,release-x.xupdated whenever new patch versions of that specific maj/min are published. We just need to constrain that patch releases don't contain breaking changes with this, otherwise we will need to specify speciifc patch versions on the version used by default (not ideal).Other:
BOUNDLESS_BUILD=..., the binaries that are specified are build from source, using pre-built native binaries no longer used by default