BM-2493: Update dockerfile and ansible to use pre-built dockerfiles#1674
Draft
austinabell wants to merge 3 commits intomainfrom
Draft
BM-2493: Update dockerfile and ansible to use pre-built dockerfiles#1674austinabell wants to merge 3 commits intomainfrom
austinabell wants to merge 3 commits intomainfrom
Conversation
The pattern will be that for `release-x` branches, we will constrain the prebuilt docker images to use latest minor version, and then for main when this gets backported, will switch that version to `latest`. `latest` overriden for every new release, `release-x.x` updated whenever new patch versions of that specific maj/min are published. We just need to constrain that patch releases don't contain breaking changes with this, otherwise we will need to specify speciifc patch versions on the version used by default (not ideal). Other: - CI release action switched to gh because old was deprecated and broken - Build pre-built docker images, switch default to use those images - When specifying `BOUNDLESS_BUILD=...`, the binaries that are specified are build from source, using pre-built native binaries no longer used by default
github-actions
bot
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1659 with the following additional changes:
latestinstead of latest 1.2TODO:
release-1.2branch instead ofmain:prover_version: "release-1.2"in inventory (not necessary if using all pre-built dockerfiles, can keep using main if we assume no compose breaking change compatibilities between the two, but I doubt this)prover_image_version: "1.2"if we don't do thisprover_boundless_build: "all"in nightly inventory fileprover_boundless_build: "rest_api agent"replacingprover_boundless_buildhandling. Currently the justfile handles howBOUNDLESS_BUILD=".."is handled where it unsets the dockerfile reference and builds only the services mentioned. The current ansible setup just builds all (which might work, but docker compose can be finnicky.Depending on which option taken, the ansible config can likely be cleaned up. Ideally
BOUNDLESS_BUILD=".."is set to define which services are built from scratch, docker images can be overriden for those that are (in cases of CPU only docker images), and then for when using prebuilt docker images either the git branch used defines which is used or is specified through ansible config with the versioning.