Multiple WARCs#84
Conversation
cac2627 to
5e03826
Compare
|
Rebased on PR #83 with the conditional compilation. If I don't include those changes, then not all the tests pass and I'd be submitting a PR with failing tests. |
extua
left a comment
There was a problem hiding this comment.
I've tested this now on my Debian laptop and it works, thanks for the PR!
However, I'm not able to merge this at the moment. To explain: my employment at the Bodleian Libraries ended in December 2025 and when I lost my Oxford University email address I lost my permission to push code to this repo. I've emailed my old line manager to ask if I could have permissions restored. Until then, I guess this software is officially unmaintained.
In the meantime, could you confirm that this code was produced by yourself, and not generative AI? See #81
…eference file in test
…g improving the CLI tool
|
Short update: I have admin rights on the repo again! Don't worry about the failing tests, they were failing before your changes and I should fix them separately. I've run the build from your branch on the two example warc.gz files and it produced an output.wacz archive which replayed fine in replayweb.page, so I'm confident it works. |
|
Thanks @extua - I can confirm I wrote the code. |
This PR adds support for adding multiple WARC files to a single WACZ, by adding a
from_filesfunction to theWACZinterface. The originalfrom_filefunction is kept for backwards compatability, but now hands off to thefrom_filesfunction. This involved changes to the datapackage module, to support multiple files.Also changed the CLI such that you can specify multiple WARCs, and optionally an output path.