Replace line endings in test#83
Closed
jamesdbaker wants to merge 2 commits intobodleian:mainfrom
Closed
Conversation
…eference file in test
extua
reviewed
Apr 21, 2026
Collaborator
extua
left a comment
extua
left a comment
There was a problem hiding this comment.
This would be a good candidate for conditional compilation.
Could you try annotating the function with #[cfg(target_family = "windows")]?
Merged
Contributor
Author
|
Changes made. Works on Windows, haven't tested on other systems. |
Collaborator
|
Closing this as these commits are already in #84 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
Fixes test on Windows by replacing \r\n line endings with \n when reading reference file in test.