src: codec: Fix SKIP_CRC_VALIDATION panic and hygiene - #8
Open
joaoantoniocardoso wants to merge 6 commits into
Open
src: codec: Fix SKIP_CRC_VALIDATION panic and hygiene#8joaoantoniocardoso wants to merge 6 commits into
joaoantoniocardoso wants to merge 6 commits into
Conversation
joaoantoniocardoso
marked this pull request as ready for review
July 4, 2026 01:54
patrickelectric
requested changes
Jul 21, 2026
| assert!(len >= 2, "packet must have at least two bytes to corrupt"); | ||
| buf[len - 2] = buf[len - 2].wrapping_add(1); | ||
| buf[len - 1] = buf[len - 1].wrapping_add(1); | ||
| } |
Member
There was a problem hiding this comment.
for V2, you need to check if buf[2] has first bit on.
The packet is signed (a signature has been appended to the packet).
If that's the case, the crc will be in buf[len - 13 - 2] and buf[len - 13 - 1]
| ); | ||
| assert!( | ||
| buf.is_empty(), | ||
| "F3: {} of {total} bytes remained after a single successful decode", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SKIP_CRC_VALIDATION panic, add tests, and minor codec/v2 cleanup.
Made with Cursor