remove listener#1991
Merged
Merged
Conversation
bolyachevets
requested review from
davemck513,
mengdong19,
ozamani9gh and
stevenc987
as code owners
June 23, 2026 22:03
|
❌ The last analysis has failed. |
panish16
added a commit
to panish16/namex
that referenced
this pull request
Jun 24, 2026
Removed in bcgov#1991 as emergency unblock while the lock was stale. Now that poetry.lock is regenerated with cloud-sql-connector 0.2.3, the import resolves correctly and the listener can be added back.
1 task
bolyachevets
pushed a commit
that referenced
this pull request
Jul 16, 2026
)" (#1995) This reverts commit ff94db9. Two of the five affected files (solr-synonyms-api, solr-names-updater) had already been reverted separately (#1991, #1994) after an import-source refactor moved DBConfig/setup_search_path_event_listener from the namex package to cloud_sql_connector. This commit removes the remaining setup_pg8000_close_event_listener calls from api/namex, namex-pay, and solr-admin-app, restoring all five services to a consistent state with no pg8000 close-event listener anywhere in the codebase. api/poetry.lock is left untouched since its cloud-sql-connector git pin has since moved forward for unrelated reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).