Revert "fix: add pg8000 graceful shutdown on Cloud Run scale-down" (#1972)#1995
Merged
Merged
Conversation
…gov#1972)" This reverts commit ff94db9. Two of the five affected files (solr-synonyms-api, solr-names-updater) had already been reverted separately (bcgov#1991, bcgov#1994) after an import-source refactor moved DBConfig/setup_search_path_event_listener from the namex package to cloud_sql_connector. This commit removes the remaining setup_pg8000_close_event_listener calls from api/namex, namex-pay, and solr-admin-app, restoring all five services to a consistent state with no pg8000 close-event listener anywhere in the codebase. api/poetry.lock is left untouched since its cloud-sql-connector git pin has since moved forward for unrelated reasons.
panish16
requested review from
davemck513,
mengdong19,
ozamani9gh and
stevenc987
as code owners
July 16, 2026 21:37
|
bolyachevets
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #1972.
setup_pg8000_close_event_listenerimport/call from the three services that still had it:api/namex/__init__.py,services/namex-pay/src/namex_pay/__init__.py,solr-admin-app/solr_admin/__init__.py.solr-synonyms-api,services/solr-names-updater) were already reverted separately in remove listener #1991 and temporarily remove change #1994, so they're left untouched here.api/poetry.lockis left untouched — itscloud-sql-connectorgit pin has moved forward independently since fix: add pg8000 graceful shutdown on Cloud Run scale-down #1972 for unrelated reasons, and rolling it back would be a regression unrelated to this revert.setup_pg8000_close_event_listeneranywhere in the tree after this change.Test plan