Don't update counter if value hasn't changed #2271
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now lazy-loading cards, which means the
#updateCountermethod initially has 0 items to work with, and the--card-countvariable will briefly be0before switching to the correct value once the cards load. That causes the CSS transition to fire on every Turbo navigation event.We already have the correct value for
--card-countset on the server, so the CSS will work like we want it to as long as the JS controller doesn't try to recalculate before the cards are loaded.Edit: also see #2272