Add ReverseRegistrarShim #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stevieraykatz
commented
Apr 28, 2025
Comment on lines
+4
to
+5
| /// @notice Interface for the L2 Reverse Registrar. | ||
| interface IL2ReverseRegistrar { |
There was a problem hiding this comment.
|
Going to address this problem set in #125 |
|
Benjamin J something, Jerry Piggott Brenda Cobb Randy Wilfong ensell jones
Shellie jones are trying to kill me by shooting stabbing or making my death
look like an overdose.
…On Wed, Apr 23, 2025 at 3:37 PM katzman ***@***.***> wrote:
While migrating to fully supporting ENSIP-19, our users will need a "shim"
to ensure data is not lost in the migration process. This shim will act as
the primary interface for users adjusting their "primary" name during the
data migration period and will be deprecated as soon as the migration is
complete.
------------------------------
You can view, comment on, or merge this pull request online at:
#124
Commit Summary
- c307e78
<c307e78>
Add upgradeable RegistrarController, make it EIP-7201 compliant'
- a578e14
<a578e14>
Add interface to new ENS contract, add support for setting primary to new
contract
- 5dfed4a
<5dfed4a>
Add initializer for reverse resolver contract
- 43a53a7
<43a53a7>
Add shim for migration period
- fc735bf
<fc735bf>
Add tests for Shim
- 7a0d049
<7a0d049>
lint
- 8151302
<8151302>
Testing start
- 1fc8be7
<1fc8be7>
chore: forge fmt
- 15ebd14
<15ebd14>
chore: typos
- d256095
<d256095>
forge install: openzeppelin-contracts-upgradeable
- 5214bc2
<5214bc2>
feat: use v5.0.0 of openzeppelin-contracts-upgradeable
- 34a313a
<34a313a>
feat: update tests to use OpenZeppelin Upgradeable
- 78e3f28
<78e3f28>
chore: fix typo
- afb5014
<afb5014>
Remove Upgradeable Registrar Controller from this PR's scope
- 0370a6b
<0370a6b>
Refactor to use updated ENS L2ReverseRegistrar
- 41eadb1
<41eadb1>
Refactor tests to match new L2ReverseRegistrar contract interface
File Changes
(13 files <https://github.com/base/basenames/pull/124/files>)
- *M* .gitmodules
<https://github.com/base/basenames/pull/124/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584>
(3)
- *M* foundry.toml
<https://github.com/base/basenames/pull/124/files#diff-bac743fe3d899998e32393af53af8cc7d28c89c3d7fabfa48b01361cf8d42d9b>
(14)
- *A* lib/openzeppelin-contracts-upgradeable
<https://github.com/base/basenames/pull/124/files#diff-7adadbc76079a34223bcbfbfad065ca2f46faefb8bc8d8b1575f4d06a42f49c4>
(1)
- *A* src/L2/ReverseRegistrarShim.sol
<https://github.com/base/basenames/pull/124/files#diff-9dc92c95be08ac41906a64b02bc6c615300239016c4068993dfa23e61c4deb28>
(29)
- *A* src/L2/interface/IL2ReverseRegistrar.sol
<https://github.com/base/basenames/pull/124/files#diff-e34bad1f0f1e07b089437ad956806aa7989d814851b28c4f159493c5c32c1b34>
(48)
- *M* test/RegistrarController/RegisterPrice.t.sol
<https://github.com/base/basenames/pull/124/files#diff-eebe016f8733023d6827aaedbe2f7c60ececaddd8b910e2e72e8fa40e963cc8c>
(2)
- *M* test/RegistrarController/RentPrice.t.sol
<https://github.com/base/basenames/pull/124/files#diff-5a5eb3c47968b24553e4c9b2610ee45547ad950fa35a18082e0a8af5481f76e4>
(2)
- *A* test/ReverseRegistrarShim/ReverseRegistrarShimBase.t.sol
<https://github.com/base/basenames/pull/124/files#diff-81fbe32ba3ebf1469db88759cb7435c23dd2dacb19d8b8e466a229603ed0b600>
(35)
- *A* test/ReverseRegistrarShim/SetNameForAddrWithSignature.t.sol
<https://github.com/base/basenames/pull/124/files#diff-89af3a49463bb5cd4e4133ab364e80c0bcb3f7c86177d7126bb0d8d567684f7e>
(28)
- *A* test/mocks/MockL2ReverseRegistrar.sol
<https://github.com/base/basenames/pull/124/files#diff-94f6836d86596d7ce01ca4b0e280bcdf1b7f8dc41d01a7729d3312d4a287c0d5>
(19)
- *M* test/mocks/MockPriceOracle.sol
<https://github.com/base/basenames/pull/124/files#diff-96d846a6efed6e54d180c6cd5ee5be32efa739207de69deab5ac84e1f6347737>
(4)
- *A* test/mocks/MockRegistrarController.sol
<https://github.com/base/basenames/pull/124/files#diff-a88218eebb1c48f8370288709145790783160f4473f4a77d9615d8f508a17878>
(24)
- *A* test/mocks/MockReverseResolver.sol
<https://github.com/base/basenames/pull/124/files#diff-54ef0cca450c5c3e332c46febc966579e7119ef1756e91ab013d681cefc4e8f3>
(12)
Patch Links:
- https://github.com/base/basenames/pull/124.patch
- https://github.com/base/basenames/pull/124.diff
—
Reply to this email directly, view it on GitHub
<#124>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMK7NAXTTQVKEJIUT2TP7323AB3PAVCNFSM6AAAAAB3XNGSHWVHI2DSMVQWIX3LMV43ASLTON2WKOZTGAYTKMZRG4ZTSMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating to fully supporting ENSIP-19, our users will need a "shim" to ensure data is not lost in the migration process. This shim will act as the primary interface for users adjusting their "primary" name during the data migration period and will be deprecated as soon as the migration is complete.