Skip to content

Conversation

babarot
Copy link
Owner

@babarot babarot commented Mar 20, 2025

What

  • Moved hardcoded forbidden paths from code to configuration
  • Added forbidden_paths option to the trash config section
  • Made the default list match the previous hardcoded values
  • Updated path checking to use configuration values instead of hardcoded list

Why

This addresses issue #94 where the hardcoded forbidden paths were too restrictive for certain use cases. Users reported being unable to remove files in paths like /var/tmp/ and /usr/local/*.

By making these paths configurable in config.yaml, users can now customize which paths should be protected based on their specific needs, while still maintaining safety mechanisms where appropriate. This provides more flexibility for power users while preserving the default safety restrictions for most users.

The default configuration still includes all the previous safety measures, ensuring that critical system directories remain protected unless explicitly configured otherwise.

@babarot babarot added the kind/feature A feature request; new or enhanced behavior label Mar 20, 2025
@babarot babarot merged commit 8a66ca2 into main Mar 20, 2025
5 checks passed
@babarot babarot deleted the babarot/forbidden-paths branch March 20, 2025 11:16
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 20, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [babarot/gomi](https://github.com/babarot/gomi) | patch | `v1.6.0` -> `v1.6.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>babarot/gomi (babarot/gomi)</summary>

### [`v1.6.1`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v161---2025-06-19)

[Compare Source](babarot/gomi@v1.6.0...v1.6.1)

##### New Features

- Make forbidden paths configurable by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#95
- Customise styles on the filter matching/prompt by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#101

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42MS4zIiwidXBkYXRlZEluVmVyIjoiNDAuNjEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request; new or enhanced behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant