Merge pull request #95 from babarot/babarot/forbidden-paths

Make forbidden paths configurable

Author: babarot

README.md

@@ -169,6 +169,22 @@ core:
 
     home_fallback: true # If true, fallbacks to home trash when external trash fails
 
+    forbidden_paths:    # List of paths that cannot be moved to trash for safety
+      - "$HOME/.local/share/Trash"
+      - "$HOME/.trash"
+      - "$XDG_DATA_HOME/Trash"
+      - "/tmp/Trash"
+      - "/var/tmp/Trash"
+      - "$HOME/.gomi"
+      - "/"
+      - "/etc"
+      - "/usr"
+      - "/var"
+      - "/bin"
+      - "/sbin"
+      - "/lib"
+      - "/lib64"
+
   restore:
     confirm: false      # If true, prompts for confirmation before restoring (yes/no)
     verbose: true       # If true, displays detailed restoration information

internal/cli/put.go

@@ -13,29 +13,6 @@ import (
 	"golang.org/x/sync/errgroup"
 )
 
-// List of forbidden paths that cannot be moved to trash
-var forbiddenPaths = []string{
-	// Default trash-related paths
-	"$HOME/.local/share/Trash",
-	"$HOME/.trash",
-	"$XDG_DATA_HOME/Trash",
-	"/tmp/Trash",
-	"/var/tmp/Trash",
-
-	// gomi dir
-	"$HOME/.gomi",
-
-	// Critical system directories
-	"/",
-	"/etc",
-	"/usr",
-	"/var",
-	"/bin",
-	"/sbin",
-	"/lib",
-	"/lib64",
-}
-
 // Put moves files to trash
 func (c *CLI) Put(args []string) error {
 	slog.Debug("cli.put started")
@@ -80,7 +57,7 @@ func (c *CLI) processFile(arg string, failed *syncStringSlice) error {
 	}
 
 	// Check for forbidden paths
-	if isForbiddenPath(expandedPath) {
+	if c.isForbiddenPath(expandedPath) {
 		failed.Append(arg)
 		return fmt.Errorf("refusing to remove forbidden path: %q", arg)
 	}
@@ -161,10 +138,10 @@ func expandPath(path string) (string, error) {
 }
 
 // isForbiddenPath checks if the given path is in the forbidden paths list
-func isForbiddenPath(path string) bool {
+func (c *CLI) isForbiddenPath(path string) bool {
 	path = filepath.Clean(path)
 
-	for _, forbiddenPath := range forbiddenPaths {
+	for _, forbiddenPath := range c.config.Core.Trash.ForbiddenPaths {
 		// Expand forbidden path with environment variables
 		expandedForbiddenPath := os.ExpandEnv(forbiddenPath)
 		expandedForbiddenPath = filepath.Clean(expandedForbiddenPath)

internal/config/config.go

@@ -51,6 +51,9 @@ type TrashConfig struct {
 
 	// GomiDir specifies the trash directory for legacy mode
 	GomiDir string `yaml:"gomi_dir" validate:"omitempty,validDirPath"`
+
+	// List of forbidden paths that cannot be moved to trash
+	ForbiddenPaths []string `yaml:"forbidden_paths"`
 }
 
 // RestoreConfig defines settings for file restoration behavior

internal/config/defaults.go

@@ -16,6 +16,25 @@ func NewDefaultConfig() *Config {
 				Strategy:     "auto",
 				HomeFallback: true,
 				GomiDir:      filepath.Join(homedir, ".gomi"),
+				ForbiddenPaths: []string{
+					// Default trash-related paths
+					"$HOME/.local/share/Trash",
+					"$HOME/.trash",
+					"$XDG_DATA_HOME/Trash",
+					"/tmp/Trash",
+					"/var/tmp/Trash",
+					// gomi dir
+					"$HOME/.gomi",
+					// Critical system directories
+					"/",
+					"/etc",
+					"/usr",
+					"/var",
+					"/bin",
+					"/sbin",
+					"/lib",
+					"/lib64",
+				},
 			},
 			Restore: RestoreConfig{
 				Confirm: true,