Skip to content

Exclude hidden files from example folder during test file collection #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

rakshil14-2
Copy link

@rakshil14-2 rakshil14-2 commented Jun 4, 2025

Description of changes:
Tests cases were failing for the users who use Mac Finder that creates hidden system files such as .DS_Store or ._command-name.rst in the directory. Thus, when the test suite is running, it fails because it encounters a unwanted files in the examples folder that has not a .rst or .txt extension.

Resolution
System-generated files like .DS_Store and other hidden files like .command-name.rst are starting with . followed by the file name, hence while gathering all the files having extension other than .rst file, the files starting with . were ignored, making the test suite free from hidden files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (5f07db1) to head (877c890).
Report is 203 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9530      +/-   ##
===========================================
+ Coverage    93.39%   93.41%   +0.02%     
===========================================
  Files          210      211       +1     
  Lines        16983    17020      +37     
===========================================
+ Hits         15861    15899      +38     
+ Misses        1122     1121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rakshil14-2 rakshil14-2 marked this pull request as ready for review June 4, 2025 22:08
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Please squash before merging, see https://aws.github.io/aws-cli/git_workflows.html#commit-message-formatting for conventions, @kdaily can probably help if you have any questions.

Updated the comment

Resolving the edge case of hidden file
@rakshil14-2 rakshil14-2 force-pushed the rhmodi/fixed_test_example branch from 5e34634 to 877c890 Compare June 10, 2025 15:12
@kdaily kdaily merged commit 7e4b09e into aws:develop Jun 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants